From: Philip Withnall <pwithnall@gnome.org>
Date: Mon, 3 Mar 2025 18:48:10 +0000 (+0000)
Subject: breakManager: Allow break to be taken or delayed when overdue
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~143^2^2~35
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e9506971562e3da139f9037698e8e4a828d9895f;p=gnome-shell.git

breakManager: Allow break to be taken or delayed when overdue

This makes the buttons on the ‘break overdue’ notification match those
on the ‘time to take a break’ notification. This makes more sense than
showing no buttons on the former, because it leads on from the ‘time to
take a break’ notification after a short wait.

By adding a ‘Take’ button it gives the user a path to acknowledge that
they are starting to take their break, rather than having to let the
session idle.

The ‘break overdue’ notification wasn’t on the original design[1], which is
probably why its buttons got overlooked.

[1]: https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/wellbeing/wellbeing.png

Signed-off-by: Philip Withnall <pwithnall@gnome.org>
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3656>
---

diff --git a/js/misc/breakManager.js b/js/misc/breakManager.js
index 6b14c2e0b..467a67bd7 100644
--- a/js/misc/breakManager.js
+++ b/js/misc/breakManager.js
@@ -1224,9 +1224,9 @@ class BreakNotificationSource extends GObject.Object {
                     title: _('Break Overdue'),
                     body: bodyText,
                     sound: null,
-                    allowDelay: false,
+                    allowDelay: true,
                     allowSkip: false,
-                    allowTake: false,
+                    allowTake: true,
                 });
 
                 this._scheduleUpdateState(updateTimeoutSeconds);